Skip to content

Conversation

sentrivana
Copy link
Contributor

@sentrivana sentrivana commented Oct 2, 2025

Description

Even though we try to figure out the current release automatically if it's not provided, it can still end up being None. If that's the case, it won't be attached to logs. The test_logs_attributes test assumes there always is a release, which is incorrect.

I opted for conditionally checking for sentry.release in the test instead of removing the check altogether, even though the test itself is supposed to test custom user provided attributes. The reason is that there is no other generic logs test testing sentry.release.

Issues

Closes #4878

Reminders

@sentrivana sentrivana marked this pull request as ready for review October 2, 2025 14:11
@sentrivana sentrivana requested a review from a team as a code owner October 2, 2025 14:11
@sentrivana sentrivana merged commit f3e8a5c into master Oct 3, 2025
113 checks passed
@sentrivana sentrivana deleted the ivana/fix-test-failures branch October 3, 2025 06:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

test_logs_attributes fails

2 participants